Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: after icons & suffix #61

Closed
wants to merge 2 commits into from

Conversation

mertasan
Copy link
Contributor

@mertasan mertasan commented Feb 3, 2021

for: #60

@mertasan mertasan mentioned this pull request Feb 3, 2021
@mertasan mertasan changed the title new: append icon & append prefix new: after icons & suffix Feb 3, 2021
@tanthammar
Copy link
Owner

Thank you for your help!

I released a slightly different version inspired by yours, so I am closing this PR.
(The position of the error icon was incorrect)

@tanthammar tanthammar closed this Feb 3, 2021
@mertasan
Copy link
Contributor Author

mertasan commented Feb 4, 2021

Thank you.

By the way:
You can request an arrangement. You can then apply your own changes and publish a version. My last 3-4 PR were rejected for the same reason. If you do it this way, nobody will rise in the contributor list. :))

@tanthammar
Copy link
Owner

@mertasan Apologies.
I didn't think of it in that way.

You are already no1 in my mind :)

@mertasan
Copy link
Contributor Author

mertasan commented Feb 4, 2021

No need to apologize. GitHub is also like a career history. Therefore I care. Thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants