Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues found by Coverity Scan in tscSQLParser.c (branch: 2.6) #15682

Closed
xiaopingcs opened this issue Aug 2, 2022 · 0 comments
Closed

fix issues found by Coverity Scan in tscSQLParser.c (branch: 2.6) #15682

xiaopingcs opened this issue Aug 2, 2022 · 0 comments
Labels
good first issue Good for newcomers improvement Improve the code readability

Comments

@xiaopingcs
Copy link
Contributor

Bug Description
fix issues found by Coverity Scan in TDengine/src/client/src/tscSQLParser.c

To Reproduce
N/A

Expected Behavior
fix following issues:

Type Category Function Line Number
Out-of-bounds access Memory - corruptions doValidateSubquery Various
Logically dead code Control flow issues setKeepOption Various
Time of check time of use Security best practices violations readFromFile 433
Logically dead code Control flow issues getTimeRange 6759
Resource leak Resource leaks handleUserDefinedFunc 523
Unsigned compared against 0 Control flow issues validateSQLExprItem 5309
Improper use of negative value Integer handling issues addExprAndResultField 2950
Copy-paste error Incorrect expression checkAndSetJoinCondInfo 4992
Unchecked return value Error handling issues parseSlidingClause 1490
Explicit null dereferenced Null pointer dereferences exprTreeFromSqlExpr 10972
Logically dead code Control flow issues validateSQLExprItemSQLFunc 5193
Use after free Memory - illegal accesses validateWhereNode 6624
Improper use of negative value Integer handling issues handleExprInQueryCond Various

Screenshots
N/A

Environment (please complete the following information):
N/A

Additional Context
above issues found by https://scan.coverity.com/projects/tdengine?tab=overview

@xiaopingcs xiaopingcs added good first issue Good for newcomers improvement Improve the code readability labels Aug 2, 2022
@xiaopingcs xiaopingcs changed the title fix issues found by Coverity Scan in tscSQLParser.c fix issues found by Coverity Scan in tscSQLParser.c (branch: 2.6) Aug 2, 2022
@yu285 yu285 closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improve the code readability
Projects
None yet
Development

No branches or pull requests

2 participants