Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserifyed latest version doesn't work with in IE8 #54

Closed
JamesKyburz opened this issue Dec 6, 2013 · 2 comments
Closed

Browserifyed latest version doesn't work with in IE8 #54

JamesKyburz opened this issue Dec 6, 2013 · 2 comments

Comments

@JamesKyburz
Copy link

Since stream-combiner was introduced IE8 fails

Using string.prototype.split with regex makes the tap output incorrect due to IE < 9 string split bugs

https://github.com/dominictarr/split

Using Array.prototype.forEach in duplexer fails as it doesn't exist in IE < 9

https://github.com/Raynos/duplexer

I can help to fix these issues but first wanted your advise in how to deal with browser incompatibility issues.

Shall we
a.) Fix duplexer and split with a browser shim/ a fall back method?
b.) Fix browserify to add these shims automatically?
c.) ???

@ghost
Copy link

ghost commented Mar 5, 2014

This was fixed back in 2.3.1 by dropping split and stream-combiner. Closing. I think I also sent some patches upstream. Anyways everything works great on the latest tape down to ancient IEs.

@ghost ghost closed this as completed Mar 5, 2014
@JamesKyburz
Copy link
Author

Great thx

Sent from a device you can call at 0046734448489

On 5 mar 2014, at 03:46, James Halliday notifications@github.com wrote:

Closed #54.


Reply to this email directly or view it on GitHub.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant