Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uncaught-exception listener #127

Merged
merged 2 commits into from
Jan 15, 2015
Merged

Remove uncaught-exception listener #127

merged 2 commits into from
Jan 15, 2015

Commits on Dec 14, 2014

  1. Remove uncaught-exception.

    @Raynos
    Raynos committed Dec 14, 2014
    Configuration menu
    Copy the full SHA
    dd661b0 View commit details
    Browse the repository at this point in the history

  2. Add back to do not call exit() if error semantics. 

    The previous commit removed the uncaught exception interception.
However that code was needed to get the process to write the
uncaught stack trace on failures.

Since messing with uncaught exception messes with the way we
exit the only way to know if exit is called from uncaught exception
is to monkey patch node core and keep track of the state
    @Raynos
    Raynos committed Dec 14, 2014
    Configuration menu
    Copy the full SHA
    9c60d32 View commit details
    Browse the repository at this point in the history