Fix spurious "test exited without ending" #374
Conversation
|
If the glob fails, the |
bin/tape
Outdated
| }); | ||
| var files; | ||
| try { | ||
| files = glob.sync(arg); |
There was a problem hiding this comment.
When in the async version would an error be generated by glob, compared to the sync version?
Separately, I appreciate that the current PR mirrors the original version's error handling precisely; but it might be better to let glob.sync's error throw, rather than having an undefined.forEach error. I'd consider that change semver-patch, since it's just making the error message more helpful.
There was a problem hiding this comment.
When in the async version would an error be generated by glob, compared to the sync version?
I expect would be generated in the same situations. The docs are unclear about which conditions generate errors. In the case that a glob matches no files, an empty array of files is returned (no error).
I agree with you about undefined.forEach being unhelpful. I will update the PR so that glob.sync throws. An alternative would be to suppress/ignore any errors (as the original code was doing).
There was a problem hiding this comment.
To my reading, the original code would still throw the undefined.forEach error, it'd just be thrown from the async callback.
|
For async logic which achieves the same goal (but in a different context), see here. |
|
The PR is updated now to address @ljharb's feedback. |
Fixes #223. @Raynos identified this line as the issue: #223 (comment) Let's finally fix this :)
|
I'll cut a release of this later today. |
|
@ljharb Nice, thanks! |
Fixes: #223
This PR ensures that all test files are required on the first tick.
To make
tapehappy, all tests need to be queued on the first tick. Tape assumes that tests are done when there's nothing in the queue.Right now, the
tapebinary is asynchronously resolving the globs and queuing up the tests as those callbacks are called. This can lead to spurious "test exited without ending" errors.@Raynos identified this line as the issue a while back #223 (comment) Let's finally fix this :)