Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to tape-player (in-process reporter) to readme. #496

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Add link to tape-player (in-process reporter) to readme. #496

merged 1 commit into from
Apr 24, 2020

Conversation

DavidAnson
Copy link
Contributor

No description provided.

@DavidAnson
Copy link
Contributor Author

If you do not approve of this approach, I will not be offended. Just reject the PR.

@ljharb
Copy link
Collaborator

ljharb commented Feb 25, 2020

Seems like it might be easier to make a test runner (a binary) instead of a side-effecting require.

@DavidAnson
Copy link
Contributor Author

I dunno, this was pretty easy. :)

But seriously, I’m not sure I understand the suggestion. If you don’t mind explaining the proposal a bit more, I’d appreciate it. I’m happy to use tape, I just didn’t want to pipe to a formatter.

@ljharb
Copy link
Collaborator

ljharb commented Feb 25, 2020

That's what I mean - make a new runner, so instead of tape foo, which they'd expect to pipe to a TAP formatter, tape-player foo, which just prints it out formatted.

@DavidAnson
Copy link
Contributor Author

I get it, thanks, but it seems weirder to me than this and maybe trickier? With how I’ve done it, the use of tape is clear in the script command and the behavior of the exit code obvious. Again, no hard feelings if you reject this PR. This works for me, but I may be the only one who likes it.

@ljharb
Copy link
Collaborator

ljharb commented Feb 25, 2020

I think it's fine, but let's move it under "other" instead. It's not a formatter, because it's not configurable or swappable - it's just something that patches tape to print "not TAP".

@ljharb ljharb merged commit 5b9c442 into tape-testing:master Apr 24, 2020
@DavidAnson DavidAnson deleted the patch-1 branch April 25, 2020 02:57
ljharb added a commit that referenced this pull request May 25, 2020
 - [Fix] `createStream`: `result` payload is not always an object (#519)
 - [Fix] Update RegExp for matching stack frames to handle Promise/then scenario (#516)
 - [readme] add `tape-repeater` (#511)
 - [readme] Add link to tape-player (in-process reporter) (#496)
 - [examples] add `ecstatic`
 - [Docs] add an optional emoji version for tap-spec consumer (#501)
 - [Deps] update `minimist`, `resolve`
 - [Tests] Fix simple typo, placehodler -> placeholder (#500)
 - [Dev Deps] update `eslint`, `falafel`, `js-yaml`
ljharb added a commit that referenced this pull request May 25, 2020
v4.13.3

 - [Fix] `createStream`: `result` payload is not always an object (#519)
 - [Fix] Update RegExp for matching stack frames to handle Promise/then scenario (#516)
 - [readme] add `tape-repeater` (#511)
 - [readme] Add link to tape-player (in-process reporter) (#496)
 - [examples] add `ecstatic`
 - [Docs] add an optional emoji version for tap-spec consumer (#501)
 - [Deps] update `minimist`, `resolve`
 - [Tests] Fix simple typo, placehodler -> placeholder (#500)
 - [Dev Deps] update `eslint`, `falafel`, `js-yaml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants