Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Refactor File entity #284

Closed
carbontwelve opened this issue Jan 2, 2018 · 2 comments
Closed

[2.0] Refactor File entity #284

carbontwelve opened this issue Jan 2, 2018 · 2 comments
Assignees
@carbontwelve
Labels
in-progress refactoring
Milestone
2.0.0

Comments

@carbontwelve
Copy link
Member

The File entity has grown in complexity and likely requires a spring clean.
@carbontwelve carbontwelve added this to the 2.0.0 milestone Jan 2, 2018
@carbontwelve
Copy link
Member Author

The File entity is being replaced with a new ProjectFile entity; this requires a lot of refactoring.

carbontwelve added a commit that referenced this issue Feb 22, 2018
@carbontwelve
(#284) Refactoring project to use ProjectFile
cdeb083
@carbontwelve carbontwelve self-assigned this Feb 22, 2018
carbontwelve added a commit that referenced this issue Feb 22, 2018
@carbontwelve
(#284) Refactored out File entity usage for ProjectFile
2ccf28b
@carbontwelve
Copy link
Member Author

This has been partly completed by 2ccf28b. Opening a new issue to expand upon this one.

@carbontwelve carbontwelve mentioned this issue Feb 23, 2018
Closed
carbontwelve added a commit that referenced this issue Feb 23, 2018
@carbontwelve
Various 2.0 Amends (#304)
13e4464 
* 🚚 added two new steps for #297 in new folder as per #282

* 🚚 drafting things out

* 🔥 disabling 1.* tests for refactoring

* 🚚 tinkering

* 🚚 filling in ProjectFile methods from File

* Refactoring to use ProjectFile

* Updating dependencies as per #270, this breaks everything...

* (#270) Update for working with 7.0

* Store uid in meta array so File object can be duplicated correctly

* (#284) Refactoring project to use ProjectFile

* (#300) Use Plates v4, this restricts us from launching 2.0 until v4 is stable

* (#284) Refactored out File entity usage for ProjectFile

* (#270) Refactored test for 7.0 - passing

* (#270) Enabling a handfull of tests - passing

* (#300) Refactored most Plates Extensions

* (#282) Refactored LoadSourceFileTree

* (#300) Refactored to use Plates v4

* Apply fixes from StyleCI (#301)

Unit tests allowed to fail

* (#270) lock file was generated on 7.2, needs removing so 7.0 unit tests "pass"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carbontwelve carbontwelve

Labels
in-progress refactoring
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@carbontwelve