Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Features #48

Merged
merged 16 commits into from
Jul 24, 2015
Merged

Miscellaneous Features #48

merged 16 commits into from
Jul 24, 2015

Conversation

harrytruong
Copy link
Contributor

Consolidating my multiple feature PRs into one. Looking forward to your feedback!

@tapio
Copy link
Owner

tapio commented Jul 24, 2015

Thanks! In principal, separate PRs for features are preferred, as then I can think about, ask for improvements, merge or decline them separately. However, I understand that I've been a bit lazy with the existing PRs and it's convenient to improve other people's PRs in one place instead of creating many "duplicate" PRs.

I'll try to be faster with feedback on issues/PRs, so that stuff gets merged faster and can be improved upon in new, separate PRs.

@harrytruong harrytruong deleted the feature-miscellaneous branch July 24, 2015 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants