Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when UNICODE defined #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

TheKrush
Copy link

Code doesn't currently compile if UNICODE is defined, this fixes that

@nabijaczleweli
Copy link
Contributor

Hello Windows my old friend...

sigh 👍

@ardi69
Copy link

ardi69 commented Jan 6, 2017

a better choice (i think):

#ifdef UNICODE
		WriteConsoleOutputCharacterA(hConsoleOutput, str, len, csbi.dwCursorPosition, &numberOfCharsWritten);
#else // UNICODE
		WriteConsoleOutputCharacter(hConsoleOutput, str, len, csbi.dwCursorPosition, &numberOfCharsWritten);
#endif // UNICODE

@hashar
Copy link

hashar commented Nov 28, 2017

@TheKrush can you amend your commit based on @ardi69 suggestion? Merely add #ifdef UNICODE :)

@hashar
Copy link

hashar commented Nov 28, 2017

There is also #48

@TheKrush
Copy link
Author

Done.

@MangaD
Copy link

MangaD commented Aug 13, 2019

There is no reason to use #ifdef UNICODE, because when UNICODE isn't defined, WriteConsoleOutputCharacter simply calls WriteConsoleOutputCharacterA.

tapio added a commit that referenced this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants