Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quite a lot of small tweaks #5

Closed
wants to merge 13 commits into from
Closed

Quite a lot of small tweaks #5

wants to merge 13 commits into from

Conversation

terah
Copy link
Contributor

@terah terah commented Jul 10, 2015

No description provided.

@taq
Copy link
Owner

taq commented Jul 10, 2015

Jesus Mary Joseph. :-)
Seems that on the last commits I made a lot of those changes, based on your fork, so I'll take a look closer on each one to see which is pendent.
Thanks!

@adaamz
Copy link
Contributor

adaamz commented Aug 2, 2015

@taq
Copy link
Owner

taq commented Aug 2, 2015

@CzechBoy , a lot of those updates I already made after I noticed @terah made them on his fork but didn't made a pull request. I think they are almost all on the code even before he sent the pull request to me. If you want, you can compare to see if something is missing.

@adaamz
Copy link
Contributor

adaamz commented Aug 2, 2015

@taq: there is warning when extending PDOOCIStatement extends \PDOStatement (arguments for fetch/bind methods are different).
Can you merge only that one (https://github.com/terah/pdooci/commit/f81b29b61779bc1901404230c9bc5f552fe3f105) commit?

@taq
Copy link
Owner

taq commented Aug 7, 2015

Hey, will take a look at it! I was very busy here those days. :-p
Today I made some adjustments on my TORM class, I'll check PDO-OCI now its done there.

@taq
Copy link
Owner

taq commented Aug 8, 2015

As we already had some changes on the code, I cherry picked by hand some of the arguments of the https://github.com/terah/pdooci/commit/f81b29b61779bc1901404230c9bc5f552fe3f105 and will commit on the next minutes, please take a look if something is still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants