Statement extends \PDOStatement implements \IteratorAggregate

[adaamz]

Make it more like PDO+PDOStatement usable.

[taq]

Argh, I'm on a client now and just missed the point of your pull request and made some lame comments, sorry. Now I see you're extending PDOStatement, nice! I'll take a look closer on it later. :-)

[taq]

Running the tests, we missed the error code returned by an invalid statement. I'll take a look on it.

[taq]

Seems the queryString on Statement, when extending PDOStatement, gives an error because is then read-only. If we extend, we need to deal with the PDOStatement constructor, to need to check if all the current behaviours are ok.

[adaamz]

We can remove line 55. querystring is used nowhere.

[taq]

Yeah, I removed it here and it worked. Can you run the test suite without it and see if there is no other errors about extending the class?

[adaamz]

Sorry I don't have access to server with Oracle database on which I can test it :(
But I use this class on website which runs well :)

[taq]

Np, so I'll take a look on it, I have a server for testing.
Em 23/07/2015 10:40, "Adam Žurek" notifications@github.com escreveu:

Sorry I don't have access to server with Oracle database on which I can
test it :(
But I use this class on website which runs well :)

—
Reply to this email directly or view it on GitHub
#6 (comment).

[taq]

Just run the tests here, everything seems ok. I made some tweaks and upgraded the Composer version. thank you! :-)

[adaamz]

Thanks, I will update composer :-)