Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create survival2d.is-an.app #13

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Conversation

tiennm99
Copy link
Contributor

Add CNAME to my current personal blog

Plan

I make it for my project in school, but current it have not done yet. So I make a CNAME point to my personal blog as a holder

Link to Website

Link: https://miti99.eu.org

Add CNAME to my current personal blog
@github-actions
Copy link

github-actions bot commented Nov 16, 2022

Your PR has been created! Please now wait for a maintainer to approve it.

Made a mistake in the record?

Don't worry, you can edit the changes in your repo and they should automatically be added to this PR.

Please, make sure that your PR passes the following checklist:

  • ⭐ You have starred this repository
  • 🗒 The file with your subdomain has a .json extension, doesn't contain comments (// ...), and is well formatted (indent size - 2 spaces)
  • 👤 There is sufficient information in the owner field
  • 📋 You have clearly described a reason for the domain registration (and what you plan to use it for) in the PR description
  • 🔗 The website is reachable and a link to it is in the PR description
  • ✅ All CI checks are passed

@tarampampam
Copy link
Owner

Wrong file name, add the .json at the end, please

survival2d.is-an.app Outdated Show resolved Hide resolved
Add dot after domain

Co-authored-by: Paramtamtam <7326800+tarampampam@users.noreply.github.com>
Copy link
Owner

@tarampampam tarampampam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change file extension

Copy link
Owner

@tarampampam tarampampam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old file is not needed, right?

@tiennm99
Copy link
Contributor Author

The old file is not needed, right?

Yes, I don't see it in my branch so I add new file instead

@tarampampam
Copy link
Owner

Take a look into the repository root directory

@tiennm99
Copy link
Contributor Author

Take a look into the repository root directory

Okay, I see & delete it. Thank you

Copy link
Owner

@tarampampam tarampampam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subdomain and filename did not match

@tarampampam tarampampam merged commit 46e872b into tarampampam:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants