Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2pt] Add a table with feature comparison of Python connectors #2482

Merged
merged 10 commits into from
Jan 26, 2022
Merged

[2pt] Add a table with feature comparison of Python connectors #2482

merged 10 commits into from
Jan 26, 2022

Conversation

ligurio
Copy link
Member

@ligurio ligurio commented Dec 6, 2021 •
edited
Loading

Patch adds a table with comparison of Python connectors for Tarantool:

  • asynctnt
  • gtarantool
  • tarantool-python

Dmitry Shveenkov (@shveenkov), Igor Latkin (@igorcoding), FYI.

@ligurio ligurio marked this pull request as draft December 6, 2021 15:58
@github-actions github-actions bot temporarily deployed to translation-python-connectors December 6, 2021 16:00 Inactive
@github-actions github-actions bot temporarily deployed to branch-python-connectors December 6, 2021 16:01 Inactive
@ligurio ligurio marked this pull request as ready for review December 6, 2021 16:26
@ligurio ligurio marked this pull request as draft December 6, 2021 16:26
@ligurio ligurio marked this pull request as ready for review December 6, 2021 19:30
@ligurio ligurio force-pushed the ligurio/python-connectors branch 3 times, most recently from a6fe53f to 50b363a Compare December 6, 2021 19:52
@Totktonada
Copy link
Member

image

https://develop.tarantool.io/en/doc/python-connectors/book/connectors/#feature-comparison

@NickVolynkin Can we do something with that?

@Totktonada
Copy link
Member

Totktonada commented Dec 6, 2021 •
edited
Loading

(And links in the last column are not clickable.)

@Totktonada
Copy link
Member

I have several more things I would like to clarify, but I want to dive a bit into the context and come back with more details.

@Totktonada Totktonada self-requested a review December 8, 2021 04:15
@ligurio ligurio force-pushed the ligurio/python-connectors branch 3 times, most recently from 83c4f41 to 60ba235 Compare December 8, 2021 14:57
@ligurio
Copy link
Member Author

ligurio commented Dec 8, 2021

Rename "Estimation of importance of known bugs" -> "Known Issues".

Totktonada
Totktonada approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. Please, proceed with the documentation team.

This was referenced Jan 19, 2022
Closed
Merged
@Totktonada
Copy link
Member

Please, ask me for review after the translation will be ready.

@Totktonada Totktonada self-requested a review January 25, 2022 11:18
Totktonada
Totktonada reviewed Jan 25, 2022
View reviewed changes
doc/book/connectors/__python.rst Outdated
Comment on lines 139 to 142
* - Access tuple fields by names
- No
- No
- Yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Yes, No, No.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patiencedaur Please, just fix it. It is obvious mistake and I don't want to let Sergey spin here yet again.

Totktonada
Totktonada reviewed Jan 25, 2022
View reviewed changes
doc/book/connectors/__python.rst
tarantool-python. aiotarantool is absent there because it is quite outdated and
unmaintained.

Feature comparison
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we have two docs regarding connectors in different sections (that's odd and confusing), but as result we end up with the comparison tables in different sections (see PR #2484).

Copy link
Contributor

@patiencedaur patiencedaur Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We noticed that and filed an issue: #2591

Totktonada
Totktonada reviewed Jan 25, 2022
View reviewed changes
locale/ru/LC_MESSAGES/book/connectors.po Outdated
Comment on lines 1000 to 1004
msgid "Support retrying when appropriate"
msgstr "Повторная отправка запросов"

msgid "Implicit reconnecting strategy"
msgstr "Стратегия повторного подключения"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь стоит выровнять с тем, как будет в PR #2484 (см. мои комментарии).

Totktonada
Totktonada approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving comments above (no need to re-review with me after the changes).

@patiencedaur patiencedaur merged commit 8875d37 into latest Jan 26, 2022
@patiencedaur patiencedaur deleted the ligurio/python-connectors branch January 26, 2022 07:32
@ligurio
Copy link
Member Author

ligurio commented Feb 3, 2022

Probably we should add a link to comparisons of Go/Python connectors on page https://www.tarantool.io/ru/download/connectors. @Totktonada, @DifferentialOrange, what do you think?

@DifferentialOrange
Copy link
Member

Probably we should add a link to comparisons of Go/Python connectors on page https://www.tarantool.io/ru/download/connectors. @Totktonada, @DifferentialOrange, what do you think?

I think we have too many different connector pages and it wasn't planned to be like this

@Totktonada
Copy link
Member

+1 to Georgy. While it is in such unclear state, I can't find any logic here and so can't think around.

@patiencedaur Is the problem on track?

@patiencedaur
Copy link
Contributor

Just to be clear, too many different connector pages is two pages?
https://www.tarantool.io/ru/download/connectors
https://www.tarantool.io/ru/doc/latest/book/connectors/

Please let me know if there are any more connector-related pages you'd like to see squashed. After that, I'll create an issue.

@Totktonada
Copy link
Member

Those two are the same. But there are two different ones. Say, for tarantool-python:

doc/getting_started/getting_started_python.rst
doc/book/connectors/__python.rst

Or for go-tarantool:

doc/getting_started/getting_started_go.rst
doc/book/connectors/__go.rst

And likely others.

@patiencedaur
Copy link
Contributor

patiencedaur commented Feb 4, 2022 •
edited
Loading

Thank you! It will most likely be part of our restructuring epic, which is now planned for Q3–Q4.
#2667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patiencedaur patiencedaur patiencedaur left review comments

@art-dr art-dr art-dr left review comments

@DifferentialOrange DifferentialOrange DifferentialOrange left review comments

@Totktonada Totktonada Totktonada approved these changes

@NickVolynkin NickVolynkin Awaiting requested review from NickVolynkin

Assignees

@maryartkey maryartkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ligurio @Totktonada @DifferentialOrange @patiencedaur @art-dr @maryartkey