Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error assertions print return value #134

Merged
merged 1 commit into from
May 31, 2021
Merged

Error assertions print return value #134

merged 1 commit into from
May 31, 2021

Conversation

Steap2448
Copy link
Contributor

@Steap2448 Steap2448 commented May 27, 2021 •
edited
Loading

If no error is generated during function call then assert_error_msg_ assertions will print return value like this:

Function successfully returned: 4
Expected error: "bla bla bla"

I didn't forget about

  • Tests
  • Changelog
  • Documentation (unnecessary)

Close #127

@Steap2448 Steap2448 requested a review from rosik May 27, 2021 01:53
@Steap2448 Steap2448 changed the title Error assertions print returned value Error assertions print return value May 31, 2021
@Steap2448 Steap2448 force-pushed the 127-enchance-error-msg-equals branch from 0565bc5 to d5eb8db Compare May 31, 2021 09:26
@Steap2448 Steap2448 merged commit 9222190 into master May 31, 2021
@Steap2448 Steap2448 deleted the 127-enchance-error-msg-equals branch May 31, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosik rosik rosik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance assert_error_msg_equals message
2 participants
@Steap2448 @rosik