Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memtier benchmark #81

Closed
ligurio opened this issue Dec 1, 2021 · 0 comments · Fixed by #84
Closed

Fix memtier benchmark #81

ligurio opened this issue Dec 1, 2021 · 0 comments · Fixed by #84
Assignees
@ligurio
Labels
testing
Milestone
wishlist

Comments

@ligurio
Copy link
Member

ligurio commented Dec 1, 2021

there is a memtier benchmark added in commit a3e2815:

sergeyb@pony:~/sources/MRG/memcached$ ls -la test/bench/
total 1112
drwxrwxr-x  2 sergeyb sergeyb    4096 дек  1 19:03 .
drwxrwxr-x 11 sergeyb sergeyb    4096 дек  1 18:58 ..
-rw-r--r--  1 sergeyb sergeyb    1948 дек  1 14:14 00000000000000000000.snap
-rw-rw-r--  1 sergeyb sergeyb       0 ноя 30 16:29 .gitignore
-rw-rw-r--  1 sergeyb sergeyb     335 дек  1 19:03 memcached.lua
-rwxrwxr-x  1 sergeyb sergeyb 1106496 дек  1 14:19 memtier_benchmark
-rw-rw-r--  1 sergeyb sergeyb    8309 ноя 30 16:29 README.md
sergeyb@pony:~/sources/MRG/memcached$

However, it is not possible to run benchmark automatically. Need to fix it and integrate to CI.
@ligurio ligurio added the testing label Dec 1, 2021
ligurio added a commit that referenced this issue Dec 1, 2021
@ligurio
Replace Travis CI with GH Actions
bbf0eee 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
ligurio added a commit that referenced this issue Dec 1, 2021
@ligurio
Add memtier benchmark to testing
f7edb2a 
TODO: add target to CMake

Closes #81
@ligurio ligurio mentioned this issue Dec 1, 2021
Merged
ligurio added a commit that referenced this issue Dec 1, 2021
@ligurio
Replace Travis CI with GH Actions
ef01a4c 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
ligurio added a commit that referenced this issue Dec 1, 2021
@ligurio
Add memtier benchmark to testing
c0b7060 
Closes #81
ligurio added a commit that referenced this issue Dec 1, 2021
@ligurio
Replace Travis CI with GH Actions
9909375 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
ligurio added a commit that referenced this issue Dec 1, 2021
@ligurio
Add memtier benchmark to testing
a71a9d1 
Closes #81
ligurio added a commit that referenced this issue Dec 2, 2021
@ligurio
Add a test with memtier benchmark
06a9eb9 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.lua
$ test/test-run.py bench/memcached.lua
$ make test-memcached-bench

Closes #81
ligurio added a commit that referenced this issue Dec 2, 2021
@ligurio
Add a test with memtier benchmark
e6dd84e 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.lua
$ test/test-run.py bench/memcached.lua
$ make test-memcached-bench

Closes #81
ligurio added a commit that referenced this issue Dec 2, 2021
@ligurio
Replace Travis CI with GH Actions
5df2b1a 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
@ligurio ligurio self-assigned this Dec 2, 2021
@ligurio ligurio added the teamE label Dec 2, 2021
ligurio added a commit that referenced this issue Dec 2, 2021
@ligurio
Replace Travis CI with GH Actions
294090e 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
ligurio added a commit that referenced this issue Dec 3, 2021
@ligurio
Add a test with memtier benchmark
87422f0 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.lua
$ test/test-run.py bench/memcached.lua
$ make test-memcached-bench

Closes #81
@kyukhin kyukhin added this to the wishlist milestone Dec 10, 2021
ligurio added a commit that referenced this issue Dec 15, 2021
@ligurio
ci: replace Travis CI with GH Actions
0807f11 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
ligurio added a commit that referenced this issue Dec 15, 2021
@ligurio
Add a test with memtier benchmark
44f74e2 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.lua
$ test/test-run.py bench/memcached.lua
$ make test-memcached-bench

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
ci: replace Travis CI with GH Actions
e372925 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
d8348df 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.test.lua
$ test/test-run.py bench/memcached.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
fe9e87b 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.test.lua
$ test/test-run.py bench/memcached.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test-run: bump version
a0c16b5 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
c1dd6ac 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memcached.test.lua
$ test/test-run.py bench/memcached.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
ddee3f7 
memtier benchmark has been added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test-run: bump version
90b7631 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
3e9f0ec 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
bc1c779 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test-run: bump version
8fcbb98 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Dec 16, 2021
@ligurio
test: add a test with memtier benchmark
fb63e23 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 20, 2021
@ligurio
test-run: bump version
ea9ccb9 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Dec 20, 2021
@ligurio
test: add a test with memtier benchmark
148629a 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 27, 2021
@ligurio
test-run: bump version
75fe48c 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Dec 27, 2021
@ligurio
test: add a test with memtier benchmark
8e13b92 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Dec 29, 2021
@ligurio
test-run: bump version
fab5e3b 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Dec 29, 2021
@ligurio
test: add a test with memtier benchmark
49a17e5 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Jan 10, 2022
@ligurio
test-run: bump version
857df93 
test-run is too old and doesn't support TAP tests.

Part of #81
ligurio added a commit that referenced this issue Jan 10, 2022
@ligurio
test: add a test with memtier benchmark
99dc668 
memtier is a benchmark made by RedisLabs for load-generation and
benchmarking of NoSQL key-value databases. memtier benchmark has been
added in commit 'Add memtier benchmark'
(a3e2815). It was added to build, but
it's run was not automated. This patch adds a test that wraps memtier
benchmark and allows to run it using test-run.py or pure tarantool:

$ tarantool test/bench/memtier.test.lua
$ test/test-run.py bench/memtier.test.lua
$ make test-memcached-bench

Memtier benchmark has been enabled on CI.

Closes #81
ligurio added a commit that referenced this issue Jan 14, 2022
@ligurio
test: fixes for memtier benchmark wrapper
6c4d725 
Suppress output with DEVNULL instead of PIPE when test-run is used for
running benchmark and reflect test run status in exit code.

Follows up #81
@ligurio ligurio mentioned this issue Jan 14, 2022
Merged
ligurio added a commit that referenced this issue Jan 14, 2022
@ligurio
test: fixes for memtier benchmark wrapper
11fb712 
Suppress output with DEVNULL instead of PIPE when test-run is used for
running benchmark and reflect test run status in exit code.

Follows up #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ligurio ligurio

Labels
testing
Projects
None yet
Milestone
wishlist
Development

Successfully merging a pull request may close this issue.

Fix memtier: add a TAP-wrapper, bump memtier version, add to CI tarantool/memcached
2 participants
@ligurio @kyukhin