cpu metrics: introduce metrics to gather cpu usage #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kasen
suggested changes
Apr 1, 2021
zwirec
force-pushed
the
add-cpu-usage-metrics
branch
from
3d0f99a
to
f578eac
Compare
|
|
||
| local function ss_get_rusage() | ||
| if ffi.C.getrusage(RUSAGE_SELF, shared_rusage) < 0 then | ||
| return -1 |
There was a problem hiding this comment.
different return contract
zwirec
force-pushed
the
add-cpu-usage-metrics
branch
from
f578eac
to
e36ab84
Compare
filonenko-mikhail
approved these changes
Apr 5, 2021
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new default metrics:
cpu_user_time- total cpu user time consumptioncpu_system_time- total cpu system time consumptionThese metrics are slightly similar to those added in #69 but the
getrusage()function call via ffi is used to get data.There aren't cpu usage per tarantool threads as in #69 but only for the whole tarantool instance.
It is proposed to add these metrics to the default so that in all the services that we ship we can understand why tarantool broke.
I didn't forget about
Close #41