MVP #1
Merged
MVP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidVas
force-pushed
the
lvasiliev/MVP
branch
3 times, most recently
from
e5e4762
to
8b6ab9d
Compare
Totktonada
reviewed
Feb 20, 2021
There was a problem hiding this comment.
Some questions and thoughts to think around. Written mostly while scratching the head at first look at the code.
If we'll consider it as review, my opinion is the following. We should finish the following points right now, when our minds are here:
- Describe API in the README.
- Define and document guarantees (and describe what may going bad / where we have no guarantees).
- Describe possible corner cases and what to do if one of them occurs.
- Elaborate naming: the repository name and terms used in the code.
- Elaborate code layout (and how it supposed to evolve).
- Clarify further areas for improvements.
Everything else can be postponed.
Totktonada
reviewed
Feb 20, 2021
Totktonada
reviewed
Feb 20, 2021
Switch to using a "mkrepo" from "pip" instead submodules.
LeonidVas
force-pushed
the
lvasiliev/MVP
branch
2 times, most recently
from
610f524
to
79fe22f
Compare
Totktonada
reviewed
Apr 20, 2021
Add MVP of the RWS microservice designed to interact with the repository via HTTP. The microservice can now upload rpm/deb packages to S3 using the "mkrepo" tool to generate metainformation. Closes tarantool/tarantool#5494
For http requests authentication has been added.
Credentials(in JSON format) can be set in two ways:
- set in the config(section "credentials" in the section "common")
- set using environment variable "SERVICE_CREDENTIALS"
Example:
'''
export SERVICE_CREDENTIALS='{"leo": "pbkdf2:sha256:150000$sovXBroE$c9653bf17752cb64d482706a00ad06e08525b55ae30a647dc69f533e08faf9a2"}'
'''
To get a hash of the password (to add it to credentials)
the following command can be used:
'''
python3 -c "from werkzeug.security import generate_password_hash; print(generate_password_hash('password'))"
'''
Add a requirements.txt file for the simplest installation of all dependencies.
LeonidVas
force-pushed
the
lvasiliev/MVP
branch
from
79fe22f
to
08be75c
Compare
LeonidVas
force-pushed
the
lvasiliev/MVP
branch
from
08be75c
to
ad77795
Compare
LeonidVas
force-pushed
the
lvasiliev/MVP
branch
from
ad77795
to
f0a378d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The microservice can now upload rpm/deb packages to S3 using the "mkrepo" tool to generate metainformation.