New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish workflow and tests on self-hosted mac os runners do not work. #840

Closed

psergee opened this issue May 7, 2024 · 2 comments · Fixed by #842

Assignees

Labels

Collaborator

psergee commented May 7, 2024

Currently full ci tests do not pass on mac os due to already running etcd processes on self-hosted runners.
tt packaging (publish workflow) also fails after mac os version update on github runners:

In file included from ../../../../go/pkg/mod/github.com/tarantool/go-openssl@v0.0.8-0.20230307065445-720eeb389195/alloc.go:3:
./shim.h:21:10: fatal error: 'openssl/bio.h' file not found
#include <openssl/bio.h>
^~~~~~~~~~~~~~~
1 error generated.

The text was updated successfully, but these errors were encountered:

psergee added bug teamE 2sp labels

Contributor

oleg-jukovec commented May 7, 2024

It could be enough to install openssl directly with brew:

https://github.com/tarantool/go-openssl/blob/576e43d9a6ce4634345a58e35cd85ce47bc1a4bd/README.md?plain=1#L28

Contributor

oleg-jukovec commented May 7, 2024

It could although help:
https://github.com/tarantool/go-openssl/blob/576e43d9a6ce4634345a58e35cd85ce47bc1a4bd/build.go#L22-L25

or

https://github.com/tarantool/go-openssl/blob/576e43d9a6ce4634345a58e35cd85ce47bc1a4bd/build_static.go#L22-L25

(maybe some paths have been changed)

oleg-jukovec assigned better0fdead

better0fdead added a commit that referenced this issue


          test: add fixture to intercept SIGTERM signal

b417175

Pytest finalizers don't run on SIGTERM only on SIGINT.
Intercept SIGTERM and send SIGINT instead.

Part of #840

better0fdead added a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

0c20240

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

better0fdead added a commit that referenced this issue


          test: add fixture to intercept SIGTERM signal

315248a

Added fixture to intercept SIGTERM signal in integration tests.
Pytest finalizers don't run on SIGTERM only on SIGINT.
Intercept SIGTERM and send SIGINT instead.
See: pytest-dev/pytest#5243

Part of #840

better0fdead added a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

94d5a4a

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

better0fdead added a commit that referenced this issue


          publish: change version of macOs for build

e3e6c98

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Closes #840

better0fdead added a commit that referenced this issue


          publish: downgrade version of macOs for github runner

6fec4e6

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Closes #840

better0fdead added a commit that referenced this issue


          publish: downgrade version of macOs for github runner

121d166

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Part of #840

better0fdead added a commit that referenced this issue


          publish: delete 'build OpenSSL 3.0' step on macOs runner

15e954c

Deleted 'build OpenSSL 3.0' step on macOs runner.
OpenSSL is already pre-installed on macOs github runners.

Closes #840

better0fdead added a commit that referenced this issue


          publish: delete 'build OpenSSL 3.0' step on macOs runner

e15fef6

Deleted 'build OpenSSL 3.0' step on macOs runner.
OpenSSL is already pre-installed on macOs github runners.

Closes #840

better0fdead added a commit that referenced this issue


          publish: delete 'build OpenSSL 3.0' step on macOs runner

be94fa1

Deleted 'build OpenSSL 3.0' step on macOs runner.
OpenSSL is already pre-installed on macOs github runners.

Closes #840

better0fdead added a commit that referenced this issue


          publish: delete 'build OpenSSL 3.0' step on macOs runner

cd4d07d

Deleted 'build OpenSSL 3.0' step on macOs runner.
OpenSSL is already pre-installed on macOs github runners.

Closes #840

better0fdead linked a pull request

that will close this issue

Fixed integration tests and publish on macOs github runners. #842

Merged

better0fdead added a commit that referenced this issue


          test: add fixture to intercept SIGTERM signal

aca840d

Added fixture to intercept SIGTERM signal in integration tests.
Pytest finalizers don't run on SIGTERM.
Intercept SIGTERM and send SIGINT instead.
See: pytest-dev/pytest#5243

Part of #840

better0fdead added a commit that referenced this issue


          ci: update tarantool version on macOs

c88289e

Updated tarantool version on macOs runner to '3.0.2'.

Part of #840

better0fdead added a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

a3b2263

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

better0fdead added a commit that referenced this issue


          publish: downgrade version of macOs for github runner

8b335d2

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Part of #840

better0fdead added a commit that referenced this issue


          publish: delete 'build OpenSSL 3.0' step on macOs runner

92dee53

Deleted 'build OpenSSL 3.0' step on macOs runner.
OpenSSL is already pre-installed on macOs github runners.

Closes #840

better0fdead added a commit that referenced this issue


          publish: fix flags for macOs build

0b4f6c7

Fixed flags for macOs build.

Closes #840

better0fdead added a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

1c29461

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

better0fdead added a commit that referenced this issue


          publish: downgrade version of macOs for github runner

a718b58

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Part of #840

better0fdead added a commit that referenced this issue


          publish: fix flags for macOs build

fc66fe6

Fixed flags for macOs build.

Closes #840

better0fdead added a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

48f3472

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

better0fdead added a commit that referenced this issue


          publish: downgrade version of macOs for github runner

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Part of #840

better0fdead added a commit that referenced this issue


          publish: fix flags for macOs build

b47ae3c

Fixed flags for macOs build.

Closes #840

better0fdead added a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

babe0b4

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

better0fdead added a commit that referenced this issue


          publish: downgrade version of macOs for github runner

6848c00

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Part of #840

better0fdead added a commit that referenced this issue


          publish: fix flags for macOs build

83df77d

Fixed flags for macOs build.

Closes #840

psergee closed this as completed in #842

psergee pushed a commit that referenced this issue


          test: add fixture to intercept SIGTERM signal

7fafdeb

Added fixture to intercept SIGTERM signal in integration tests.
Pytest finalizers don't run on SIGTERM.
Intercept SIGTERM and send SIGINT instead.
See: pytest-dev/pytest#5243

Part of #840

psergee pushed a commit that referenced this issue


          ci: update tarantool version on macOs

1824e08

Updated tarantool version on macOs runner to '3.0.2'.

Part of #840

psergee pushed a commit that referenced this issue


          ci: add step to kill etcd after integration tests on macOs

c796de5

Added step to kill etcd after integration tests on macOs, if it was left by 'tt'.

Etcd can be still running after integration tests when:
  1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
  2. when pytest crashes
In both cases finalizers are not invoked, so etcd is not stopped.

Part of #840

psergee pushed a commit that referenced this issue


          publish: downgrade version of macOs for github runner

428a1d6

Changed macOs version to 'macos-13'.
'macos-latest' uses 'arm64' processor and we need to build for 'amd64'.

Part of #840

psergee pushed a commit that referenced this issue


          publish: fix flags for macOs build

590b4cd

Fixed flags for macOs build.

Closes #840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment