Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix failed tests #931

Closed
oleg-jukovec opened this issue Aug 28, 2024 · 0 comments · Fixed by #947
Closed

ci: fix failed tests #931

oleg-jukovec opened this issue Aug 28, 2024 · 0 comments · Fixed by #947
Assignees
Labels
3sp code health Improve code readability, simplify maintenance and so on teamE

Comments

@oleg-jukovec
Copy link
Contributor

oleg-jukovec commented Aug 28, 2024

There are currently 3-4 failed CI tests. We need to fix them.

@oleg-jukovec oleg-jukovec added 3sp teamE code health Improve code readability, simplify maintenance and so on labels Aug 28, 2024
@themilchenko themilchenko changed the title ci: fix flaky tests ci: fix failed tests Sep 10, 2024
themilchenko added a commit that referenced this issue Sep 17, 2024
There are a few failed tests with replacing tarantool sdk version in CI
workflow from 3.0.0 into 3.2.0.

After the patch all failed tests related with the upgrade was fixed.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
There was problem with installation in previous tarantool 3.0.0 skd
version.

After the patch the version was upgraded to the newest one.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
There was a problem with rocks installation using `tt rocks install` in
test where tarantool doesn't exist in PATH. It was `mysql` rock which
had problems with building on system.

After the patch rock was replaced on `psql` (PostreSQL connector) due
to we test installation without `tarantool` in PATH and it is doesn't
matter which package we install.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
There was a problem in `TestInstanceLogger` test with the fact that
cleanup after the test recieves error `io: read/write on closed pipe`.

After the patch the order of pipes closing was updated by moving it to
the cleanup block. A check was also added to send a SIGKILL signal to
the process if it is alive, to avoid the `sending a signal to a killed
process` error.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
After updating tarantool sdk version to the 3.2.0 stopping instance in
`test_running_env_variables` causes an error with cleaning all logs in
json format that was written before. So it wasn't possible to determine
json format after stopping instance.

After the patch the order of distructing tarantool was moved to the
special `finally` block. Determination of json format was also updated
with `wait_string_in_file` function with special timeout.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
After updating tarantool sdk version to the 3.2.0 stopping instance in
`test_running_env_variables` causes an error with cleaning all logs in
json format that was written before. So it wasn't possible to determine
json format after stopping instance.

After the patch the order of distructing tarantool was moved to the
special `finally` block. Determination of json format was also updated
with `wait_string_in_file` function with special timeout.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
There was problem with installation in previous tarantool 3.0.0 sdk
version.

After the patch the version was upgraded to the newest one.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
There was a problem with rocks installation using `tt rocks install` in
test where tarantool doesn't exist in PATH. It was `mysql` rock which
had problems with building on system.

After the patch rock was replaced on `psql` (PostreSQL connector) due
to we test installation without `tarantool` in PATH and it is doesn't
matter which package we install.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
There was a problem in `TestInstanceLogger` test with the fact that
cleanup after the test recieves error `io: read/write on closed pipe`.

After the patch the order of pipes closing was updated by moving it to
the cleanup block. A check was also added to send a SIGKILL signal to
the process if it is alive, to avoid the `sending a signal to a killed
process` error.

Part of #931
themilchenko added a commit that referenced this issue Sep 18, 2024
After updating tarantool sdk version to the 3.2.0 stopping instance in
`test_running_env_variables` causes an error with cleaning all logs in
json format that was written before. So it wasn't possible to determine
json format after stopping instance.

After the patch the order of distructing tarantool was moved to the
special `finally` block. Determination of json format was also updated
with `wait_string_in_file` function with special timeout.

Part of #931
oleg-jukovec pushed a commit that referenced this issue Sep 18, 2024
There was problem with installation in previous tarantool 3.0.0 sdk
version.

After the patch the version was upgraded to the newest one.

Part of #931
oleg-jukovec pushed a commit that referenced this issue Sep 18, 2024
There was a problem with rocks installation using `tt rocks install` in
test where tarantool doesn't exist in PATH. It was `mysql` rock which
had problems with building on system.

After the patch rock was replaced on `psql` (PostreSQL connector) due
to we test installation without `tarantool` in PATH and it is doesn't
matter which package we install.

Part of #931
oleg-jukovec pushed a commit that referenced this issue Sep 18, 2024
There was a problem in `TestInstanceLogger` test with the fact that
cleanup after the test recieves error `io: read/write on closed pipe`.

After the patch the order of pipes closing was updated by moving it to
the cleanup block. A check was also added to send a SIGKILL signal to
the process if it is alive, to avoid the `sending a signal to a killed
process` error.

Part of #931
oleg-jukovec pushed a commit that referenced this issue Sep 18, 2024
After updating tarantool sdk version to the 3.2.0 stopping instance in
`test_running_env_variables` causes an error with cleaning all logs in
json format that was written before. So it wasn't possible to determine
json format after stopping instance.

After the patch the order of distructing tarantool was moved to the
special `finally` block. Determination of json format was also updated
with `wait_string_in_file` function with special timeout.

Part of #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Sep 24, 2024
There were a lot of problems related with docker runtime on macOS, so
the tests on it always fail.

After the patch `colima` (container runtime for macos) was added to CI
pipeline.

Closes #931
themilchenko added a commit that referenced this issue Oct 3, 2024
Sometimes CI on macos fails with an error "docker daemon not running".

To avoid it after the patch docker socket is provided in the github env
directly.

Part of #931
themilchenko added a commit that referenced this issue Oct 3, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 3, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 3, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 3, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 4, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 4, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 4, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 4, 2024
Sometimes CI on macos fails with an error "docker daemon not running".

To avoid it after the patch docker socket is provided in the github env
directly.

Part of #931
themilchenko added a commit that referenced this issue Oct 4, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 7, 2024
Sometimes CI on macos fails with an error "docker daemon not running".

To avoid it after the patch docker socket is provided in the github env
directly.

Part of #931
themilchenko added a commit that referenced this issue Oct 7, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 8, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 8, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 8, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 8, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 8, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 8, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
Sometimes CI on macos fails with an error "docker daemon not running".

To avoid it after the patch docker socket is provided in the github env
directly.

Part of #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
Sometimes CI on macos fails with an error "docker daemon not running".

To avoid it after the patch docker socket is provided in the github env
directly.

Part of #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
themilchenko added a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
oleg-jukovec pushed a commit that referenced this issue Oct 9, 2024
Sometimes CI on macos fails with an error "docker daemon not running".

To avoid it after the patch docker socket is provided in the github env
directly.

Part of #931
oleg-jukovec pushed a commit that referenced this issue Oct 9, 2024
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3sp code health Improve code readability, simplify maintenance and so on teamE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants