Setup simple Github Actions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
May 25, 2021
Totktonada
reviewed
May 25, 2021
Totktonada
reviewed
May 28, 2021
Totktonada
reviewed
May 28, 2021
Totktonada
force-pushed
the
2-setup-ci
branch
2 times, most recently
from
5d84fe5
to
dcbf7d7
Compare
Totktonada
approved these changes
May 29, 2021
There was a problem hiding this comment.
LGTM.
I splitted the changes to separate commits, added brief description of the changes, rearranged the code a bit (I asked Yaroslav and he didn't complain). That's mostly to make me more comfortable around the module's code. (How far it from madness? I don't know).
I'll wait for #12 and Yaroslav's agreement about my changes prior to merge this PR.
|
(That's fast as a rocket, I can't stop admire!) |
It eases local experimenting around rocks. Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org> Part of #2
Unlike the grand plan with different Linux distros / Mac OS, RPM / Deb packages building and verification, past and actual tarantool releases, this workflow just runs testing on several latest tarantool versions on Ubuntu Linux. However it uses the great setup-tarantool GitHub Action and so incredibly fast due to caching of tarantool and its dependencies. This workflow will give us fast CI feedback. Another nice property is that it verifies a flow similar to the user's one (`tarantoolctl rocks install <...>`). A usual development flow like `cmake . && make && make test` may miss an installation problem. Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org> Part of #2
The new worklow uploads the scm-1 rockspec on pushing a commit to master and uploads the release rockspec + .src.rock tarball at pushing a tag. This automation descrease amount of manual work to release the module. Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org> Part of #2
|
Rebased after PR #12. |
This was referenced Jun 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2