Allow to not invoke box.cfg() when vshard.*.cfg() is called #428
Assignees
Comments
|
True. Closed as a duplicate. |
|
After some thought - issue #353 about the router, and here about the router and the storage. |
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 15, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 15, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Merged
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 15, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 15, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 15, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 15, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 20, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 20, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 20, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Nov 20, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
In the following commit box.cfg in router will be disabled, it won't accept any box.cfg options and will through error, if some of them are encountered. Let's explicitly use replication_timeout, where it's needed, and don't set it inside vtest during config generation. Needed for tarantool#353 Needed for tarantool#428 NO_DOC=test
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
Part of tarantool#428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
In the following commit box.cfg in router will be disabled, it won't accept any box.cfg options and will through error, if some of them are encountered. Let's explicitly use replication_timeout, where it's needed, and don't set it inside vtest during config generation. Needed for tarantool#353 Needed for tarantool#428 NO_DOC=test
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 6, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes tarantool#353 Closes tarantool#428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
Gerold103
pushed a commit
that referenced
this issue
Dec 6, 2023
Part of #428 @TarantoolBot document Title: vshard: `box_cfg_mode` cfg option The option can be specified at the root level and regulates, whether vshard calls box.cfg, when vshard.storage is invoked. When specified to 'auto' (default), vshard configures box.cfg on its own. When specified to 'manual', it's user's responsibility to call box.cfg prior to vshard's configuration
Gerold103
pushed a commit
that referenced
this issue
Dec 6, 2023
In the following commit box.cfg in router will be disabled, it won't accept any box.cfg options and will through error, if some of them are encountered. Let's explicitly use replication_timeout, where it's needed, and don't set it inside vtest during config generation. Needed for #353 Needed for #428 NO_DOC=test
Gerold103
pushed a commit
that referenced
this issue
Dec 6, 2023
There is no reason for router to have box configured. It needs neither storage nor listening on a port. This is breaking change, so user's code, which relies on vshard.router.cfg to call box.cfg must be changed. Closes #353 Closes #428 @TarantoolBot document Title: vshard: disable box.cfg on routers Since vshard 0.1.25 vshard.router.cfg doesn't call box.cfg and this must be done manually outside of vshard.
|
Documentation request: tarantool/doc#3894. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, every time vshard.storage.cfg() or vshard.router.cfg() is called, box.cfg() is also called. This allows us to start a cluster using vshard. However, this is not necessary when vshard is run after the cluster is set up.
The text was updated successfully, but these errors were encountered: