Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: 'deploying exports' message has no core version #465

Closed
Totktonada opened this issue Dec 28, 2023 · 1 comment · Fixed by #463
Closed

log: 'deploying exports' message has no core version #465

Totktonada opened this issue Dec 28, 2023 · 1 comment · Fixed by #463
Assignees
@Serpentian
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Totktonada
Copy link
Member

Let's look on the code.

vshard/vshard/storage/exports.lua

Lines 44 to 48 in 5bfe03b

return {
vshard_version = exports.version,
core_version = table.concat(lvutil.core_version, '.'),
funcs = compiled_funcs,
}

vshard/vshard/storage/exports.lua

Lines 59 to 60 in 5bfe03b

llog.info('Deploying exports for vshard %s, core %s',
exports.vshard_version, exports.core_version)

The exports.core_version field is always an empty string.

# tarantool> lvutil = require('vshard.util')
# tarantool> lvutil.core_version
---
- id_middle: 1
  rel_type: entrypoint
  id_minor: 0
  id_major: 3
  id_commit: 9
  rel_num: 0
...
# tarantool> table.concat(lvutil.core_version, '.')
---
-
...

table.concat() concetenates an array, but not a map.
@Totktonada Totktonada added bug Something isn't working good first issue Good for newcomers labels Dec 28, 2023
@Serpentian Serpentian self-assigned this Dec 29, 2023
@Serpentian
Copy link
Contributor

#463

Serpentian added a commit to Serpentian/vshard that referenced this issue Dec 29, 2023
@Serpentian
storage: fix schema log message
2125660 
exports_deply_funcs() used to log the core version as nil. The problem
is the fact, that table.concat was used for core version string, so the
complied exports always had nil instead of core_version.

table.concat doesn't work with non-array tables, as they have no defined
order. Let's explicitly define __tostring function for version and use
it in order to log core version.

Closes tarantool#465

NO_DOC=bugfix
@Serpentian Serpentian mentioned this issue Dec 29, 2023
Merged
Serpentian added a commit to Serpentian/vshard that referenced this issue Dec 29, 2023
@Serpentian
storage: fix core_version string in exports
bdf8601 
exports_deply_funcs() used to log the core version as nil. The problem
is the fact, that table.concat was used for core version string, so the
complied exports always had nil instead of core_version.

table.concat doesn't work with non-array tables, as they have no defined
order. Let's explicitly define __tostring function for version and use
it in order to log core version.

Closes tarantool#465

NO_DOC=bugfix
Serpentian added a commit to Serpentian/vshard that referenced this issue Jan 11, 2024
@Serpentian
storage: fix core_version string in exports
fc3108a 
exports_deploy_funcs() used to log the core version as nil. The problem
is the fact, that table.concat was used for core version string, so the
complied exports always had nil instead of core_version.

table.concat doesn't work with non-array tables, as they have no defined
order. Let's explicitly define __tostring function for version and use
it in order to log core version.

Closes tarantool#465

NO_DOC=bugfix
Serpentian added a commit to Serpentian/vshard that referenced this issue Jan 11, 2024
@Serpentian
storage: fix core_version string in exports
8980218 
exports_deploy_funcs() used to log the core version as nil. The problem
is the fact, that table.concat was used for core version string, so the
complied exports always had nil instead of core_version.

table.concat doesn't work with non-array tables, as they have no defined
order. Let's explicitly define __tostring function for version and use
it in order to log core version.

Closes tarantool#465

NO_DOC=bugfix
Gerold103 pushed a commit that referenced this issue Jan 11, 2024
@Serpentian @Gerold103
storage: fix core_version string in exports
48e6e9d 
exports_deploy_funcs() used to log the core version as nil. The problem
is the fact, that table.concat was used for core version string, so the
complied exports always had nil instead of core_version.

table.concat doesn't work with non-array tables, as they have no defined
order. Let's explicitly define __tostring function for version and use
it in order to log core version.

Closes #465

NO_DOC=bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Serpentian Serpentian

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: fix schema log message Serpentian/vshard
2 participants
@Totktonada @Serpentian