Added logic for sorting the retry options #344
Conversation
|
The bottom menu needs sorting too. 
Need to unify this sorting code somewhere. Maybe do it at the point of requesting list models endpoint? |
|
Thanks for breaking this up into separate pull req |
There was a problem hiding this comment.
Let's fix this at the source, so it works for every user of models, which we get from the useModels() hook:
chatcraft.org/src/hooks/use-models.tsx
Line 57 in a24f51d
If you change the way we do the sort there, it should mean we're good in all UI situations.
Deploying with
|
| Latest commit: |
4e0dc79
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://241eb0a6.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://sorting.console-overthinker-dev.pages.dev |
src/hooks/use-models.tsx
Outdated
| @@ -54,7 +54,8 @@ export const ModelsProvider: FC<{ children: ReactNode }> = ({ children }) => { | |||
| isFetching.current = true; | |||
| try { | |||
| const models = await queryModels(apiKey).then((models) => { | |||
| models.sort(); | |||
| // models.sort(); | |||
There was a problem hiding this comment.
you can delete vs. comment-out code
Still not sorting bottom menu |
|
Given that we ultimately want the pretty names to be sorted, let's do that in the hook (i.e., convert the models to ChatCraftModel instances, then sort on the |
src/hooks/use-models.tsx
Outdated
| @@ -54,8 +54,7 @@ export const ModelsProvider: FC<{ children: ReactNode }> = ({ children }) => { | |||
| isFetching.current = true; | |||
| try { | |||
| const models = await queryModels(apiKey).then((models) => { | |||
| // models.sort(); | |||
| models.sort((a, b) => a.localeCompare(b)); | |||
| models.sort(); | |||
There was a problem hiding this comment.
Don't bother sorting here if you're going to sort again later.
src/hooks/use-models.tsx
Outdated
| @@ -74,7 +73,7 @@ export const ModelsProvider: FC<{ children: ReactNode }> = ({ children }) => { | |||
| }, [settings.apiUrl, settings.apiKey]); | |||
|
|
|||
| const value = { | |||
| models: models || defaultModels, | |||
| models: models?.sort((a, b) => a.prettyModel.localeCompare(b.prettyModel)) || defaultModels, | |||
There was a problem hiding this comment.
Do this above on line 60 so you cache the result in state vs. doing it for every consumer:
models.sort((a, b) => a.prettyModel.localeCompare(b.prettyModel))
setModels(models);
|
Fixes #316