Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Kurucz line list parser with straight to HDF5 output #146

Closed
wants to merge 28 commits into from

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jul 26, 2019

Trying to get the same DataFrames obtained with the old SQL-based classes.

  • Match _get_all_levels_data with AtomData method of the same name
  • Match _get_all_lines_data with AtomData method of the same name
  • Match levels attribute with AtomData attribute of the same name
  • Match lines attribute with AtomData attribute of the same name
  • Match levels_prepared match with AtomData attribute of the same name
  • Match lines_prepared match with AtomData attribute of the same name

https://nbviewer.jupyter.org/gist/epassaro/82be42e2491511c07bb566354927a780?flush_cache=true

  • Add to_hdf method
  • Fix for missing ions in gfall.dat
  • Figure out issue with He I. Why .drop_duplicates() is not dropping level 3?
  • Add docstrings
  • Ready to merge

@epassaro epassaro changed the title Straight to HDF5 Kurucz lines New Kurucz line list parser with straight to HDF5 output Aug 1, 2019
@wkerzendorf
Copy link
Member

all tests fail

@epassaro epassaro closed this Aug 12, 2019
@epassaro epassaro reopened this Aug 14, 2019
@epassaro epassaro closed this Aug 14, 2019
@epassaro epassaro mentioned this pull request Aug 18, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants