Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC] Abundance visualisation tool gsoc first objective #2264

Conversation

Pratyusha132
Copy link

📝 Description

Type: GSOC.

Jupyter notebook as the solution of the first objective for the GSoC'23 project "Develop an interactive abundance visualisation tool".

📌 Resources

GSoC'23 Ideas Page

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Pratyusha132 Pratyusha132 changed the title Abundance visualisation tool gsoc first objective [GSOC] Abundance visualisation tool gsoc first objective Mar 29, 2023
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@atharva-2001
Copy link
Member

atharva-2001 commented Mar 30, 2023

Can you share an nbviewer link? I wasn't able to see the plot on ReviewNB. Please also start writing a proposal since there isn't much time left.

@tardis-sn tardis-sn deleted a comment from tardis-bot Mar 30, 2023
@tardis-sn tardis-sn deleted a comment from tardis-bot Mar 30, 2023
@tardis-sn tardis-sn deleted a comment from tardis-bot Mar 30, 2023
@tardis-sn tardis-sn deleted a comment from tardis-bot Mar 30, 2023
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@Pratyusha132
Copy link
Author

Can you share an nbviewer link? I wasn't able to see the plot on ReviewNB. Please also start writing a proposal since there isn't much time left.

Hi Atharva, Here is my nbviewer link, in this link I have saved the plot in "pie_chart.png"
https://nbviewer.org/github/Pratyusha132/tardis/tree/abundance-visualisation-tool-gsoc-first-objective/tardis/visualization/

@MarkMageeAstro
Copy link
Contributor

Hi @Pratyusha132,

Nice work! This isn't really the first objective, it's more like the final product we're expecting! Anyway, it looks good. How would your pie chart handle cases where the abundance isn't uniform? Is the final value given in the last shell, e.g. Si 0.52, the overall abundance?

As @atharva-2001 says, the deadline for submission is very soon so make sure you get a proposal in!

@Pratyusha132
Copy link
Author

Hi @Pratyusha132,

Nice work! This isn't really the first objective, it's more like the final product we're expecting! Anyway, it looks good. How would your pie chart handle cases where the abundance isn't uniform? Is the final value given in the last shell, e.g. Si 0.52, the overall abundance?

As @atharva-2001 says, the deadline for submission is very soon so make sure you get a proposal in!

Yes, the final value given in the last shell is the overall abundance of each element, e.g. Si 0.52 is the overall abundance of Si. Actually, the plot is dynamic, and on hovering it, an abundance of each shell will be displayed but this dynamic plot was not displayed in ReviewNB and also in nbviewer. So, I have saved the static image of the plot which is showing the overall abundance of each element.
Also if abundance is not uniform then we can update the pie chart by putting in a different function in the code which will specifically handle the proportion of each shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants