Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests added for Montecarlo #266

Closed
wants to merge 1 commit into from

Conversation

imjalpreet
Copy link

  • Tests have been added for some basic functions in cmontecarlo.c-
  • This is still incomplete as I am still trying to get the absolute path of the file cmontecarlo.so in the tardis/montecarlo/src/ directory. (DONE)
  • For, now it works with py.test -v test_montecarlo.py but it fails with python setup.py test as the path that I have used is not from the build directory, so it results in "No such fiile or directory"
    (DONE)

@imjalpreet
Copy link
Author

@wkerzendorf Can you have a look at this and tell if it's fine? I know it will not pass the tests till I find a way to write the absolute path but can you check if it's fine otherwise?

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 5b3982a on imjalpreet:Tests_Montecarlo into dca3806 on tardis-sn:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 4ab9ba1 on imjalpreet:Tests_Montecarlo into dca3806 on tardis-sn:master.

@wkerzendorf
Copy link
Member

This looks like a good first effort. Please also think about your application.

@imjalpreet
Copy link
Author

@wkerzendorf Thanks and I am also working on my application.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 0aa79f6 on imjalpreet:Tests_Montecarlo into 4cdaaf0 on tardis-sn:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 3426b6f on imjalpreet:Tests_Montecarlo into 4cdaaf0 on tardis-sn:master.

@imjalpreet
Copy link
Author

@wkerzendorf Please have a look at this whenever you have time 😄

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 08cdb74 on imjalpreet:Tests_Montecarlo into 4cdaaf0 on tardis-sn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 55.4% when pulling 08cdb74 on imjalpreet:Tests_Montecarlo into 4cdaaf0 on tardis-sn:master.

@wkerzendorf
Copy link
Member

@imjalpreet an interesting solution using ctypes. I presume you fixed the path problems. If that is the case, please update the description of your PR (For other PRs you also make checkboxes which you check when certain things are done, that might have been useful here).

@imjalpreet
Copy link
Author

@wkerzendorf Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants