Plasma write_to_tex/dot unit tests #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vg3095
commented
Aug 23, 2017
| simulation_verysimple.plasma.write_to_dot(fname) | ||
| actual = pgv.AGraph(fname).to_string() | ||
| expected = pgv.AGraph(os.path.join(data_path, 'plasma_ref.dot')).to_string() | ||
| assert actual == expected |
There was a problem hiding this comment.
@wkerzendorf This passes on my Travis build for Ubuntu , not for Mac . And on Tardis Travis CI it fails for Ubuntu as well as for Mac. I can't understand the reason for this.
There was a problem hiding this comment.
well they are slightly different. can you post the diff of those files?
wkerzendorf
reviewed
Aug 23, 2017
.travis.yml
Outdated
| @@ -77,6 +77,8 @@ before_install: | |||
| - if [[ $TEST_MODE == 'spectrum' ]]; then git lfs pull --include="atom_data/kurucz_cd23_chianti_H_He.h5" origin; fi | |||
| - if [[ $TEST_MODE == 'spectrum' ]]; then git lfs pull --include="plasma_reference/" origin; fi | |||
| - if [[ $TEST_MODE == 'spectrum' ]]; then cd $TRAVIS_BUILD_DIR; fi | |||
| - if [[ $TRAVIS_OS_NAME == 'osx' ]]; then brew install graphviz; fi | |||
There was a problem hiding this comment.
please use conda to install graphviz
| @@ -222,7 +222,7 @@ def write_to_dot(self, fname, latex_label=True): | |||
| print_graph.node[str(node)]['label']+=label | |||
| print_graph.node[str(node)]['label']+='$' | |||
|
|
|||
| nx.write_dot(print_graph, fname) | |||
| nx.drawing.nx_agraph.write_dot(print_graph, fname) | |||
| simulation_verysimple.plasma.write_to_dot(fname) | ||
| actual = pgv.AGraph(fname).to_string() | ||
| expected = pgv.AGraph(os.path.join(data_path, 'plasma_ref.dot')).to_string() | ||
| assert actual == expected |
There was a problem hiding this comment.
well they are slightly different. can you post the diff of those files?
|
Travis complains about |
|
@wkerzendorf It is working now. |
wkerzendorf
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.