-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with custom_composition reader #843
Fix issue with custom_composition reader #843
Conversation
I changed the line 405 in model_reader.py, it still gives the error message. |
@pfreddy, @wkerzendorf - I think, the PR is ready. It passes our testing suite offline and it create data frames with the correct shape from the test_csv.dat file from @pfreddy. Whenever Tardis is happy and someone reviewed it, we should consider merging. |
Travis is happy! |
df = pd.read_csv(fname, comment='#', | ||
delimiter=delimiter, skiprows=skip_rows) | ||
sep=delimiter, skiprows=skip_rows, index_col=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename it into skiprows
to be in line with pandas
@pfreddy is checking your PR. |
Ok, I've revisited the issue and found some indexing problems in the parser which are hopefully fixed now. On my laptop, I can run your setup @pfreddy without problems. Also the testing suite runs through. If Travis is happy, I'll address your stylistic suggestion, @wkerzendorf . |
Currently, the
custom_composition
reader is not properly working since it expected an additional column containing the cell index, similar to the file struture for thesimple_ascii
reader.This PR addresses this issue by re-inserting the cell index as the first column into the
custom_composition
files.