Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #236

Merged
merged 9 commits into from
Apr 16, 2022
Merged

chore: cleanup #236

merged 9 commits into from
Apr 16, 2022

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Apr 14, 2022

  • use Go's new embedded vcs info for git hash
  • use digests for images
  • update docs for accuracy
  • updates golangci-lint to latest
  • turn dockerignore into stricter allow vs exclude list

@coveralls
Copy link

coveralls commented Apr 14, 2022

Pull Request Test Coverage Report for Build 2177904191

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 2177903770: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@wass3r wass3r marked this pull request as draft April 14, 2022 16:42
@wass3r
Copy link
Collaborator Author

wass3r commented Apr 14, 2022

this will actually not work as-is. we need the .git directory and git binary in the build context for the build stage in docker for Go to be able to pick up the revision info 🤔

@wass3r wass3r marked this pull request as ready for review April 16, 2022 16:33
@wass3r wass3r merged commit 316de94 into main Apr 16, 2022
@wass3r wass3r deleted the chore/cleanup branch April 16, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants