Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services: fix service label create dialog validation #1635

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

dctalbot
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This fixes an issue with validation on the service label create dialog:
errors={fieldErrors} -> errors={fieldErrors(error)}

Describe any introduced user-facing changes:
Working validation on form fields

@Forfold Forfold merged commit 40ff30f into master Jun 23, 2021
@Forfold Forfold deleted the fix-service-label-create-dialog branch June 23, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants