Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services: convert ServiceDeleteDialog to ts #2566

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switch out Apollo client with urql

@stale
Copy link

stale bot commented Sep 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label Sep 20, 2022
@stale stale bot removed the stale This is inactive label Oct 3, 2022
@Forfold Forfold merged commit e66f616 into master Oct 7, 2022
@Forfold Forfold deleted the ts-ServiceDeleteDialog branch October 7, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants