fix(consensus)!: deferred execution of txs with unversioned inputs #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
force-pushed
the
consensus-late-execution-fixes
branch
from
38b3138
to
960f5a3
Compare
Test Results (CI)533 tests +3 532 ✅ +2 1h 36m 53s ⏱️ - 25m 45s For more details on these failures, see this check. Results for commit b2a10fe. ± Comparison against base commit a77eda6. ♻️ This comment has been updated with latest results. |
stringhandler
previously approved these changes
Apr 30, 2024
Also includes: - Indexer: Skip autofill if no required substates are provided - Validate ID hash on transaction submits - Allow skipping fee estimate and providing a custom fee in wallet web UI - Clean up tx builder methods
stringhandler
merged commit 81d884a
into
tari-project:development
10 of 11 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Deferred execution previously had a default COMMIT decision which led to bugs when running rejected transactions (they would still get a COMMIT decision, but the validator does not have an accepted result to commit).
This PR partially implements late execution for local-only transactions. Additional work is required to support this and it has been disabled i.e. will ABORT the transaction for transactions without versions.
There was a bug where inputs without versions were provided but filled inputs for those substates were provided, the transaction would still detect that one or more inputs do not have a version.
Input refs are unnecessary because the validator will always know which substates were written at lock time.
TODOs:
How Has This Been Tested?
Existing tests pass, a new consensus unit test was written which is ignored because it fails, requires additional work to succeed, manually (previously working transactions still work).
What process can a PR reviewer use to test or verify this change?
Submit a transaction with a missing version
Breaking Changes