Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove explicit panic from rpc handshake on io error #3341

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix: remove explicit panic from rpc handshake on io error #3341

merged 1 commit into from
Sep 14, 2021

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 14, 2021

Description

Remove mistaken explicit panic

Motivation and Context

Forgot to remove panic while developing

How Has This Been Tested?

N/A

delta1
delta1 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

@hansieodendaal
Copy link
Contributor

Thanks.

I assume the thread 'tokio-runtime-worker' panicked at 'ready_rx oneshot is never dropped without a reply: RecvError(())', tari-project/comms/src/protocol/rpc/client.rs:100:14 was as a result of the first panic that you fixed, being thread 'tokio-runtime-worker' panicked at 'explicit panic', tari-project/comms/src/protocol/rpc/handshake.rs:151:13.

@aviator-app aviator-app bot merged commit c2ebfc8 into tari-project:development Sep 14, 2021
@sdbondi sdbondi deleted the comms-rpc-explicit-panic-remove branch September 15, 2021 05:17
@sdbondi sdbondi restored the comms-rpc-explicit-panic-remove branch February 3, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@delta1 delta1 delta1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdbondi @hansieodendaal @delta1 @stringhandler