-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add versioning to transaction(input,output,kernel) #3709
feat: add versioning to transaction(input,output,kernel) #3709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
Just some comments to consider.
Thanks.
base_layer/core/src/transactions/transaction/output_features.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_input.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_kernel.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_output.rs
Outdated
Show resolved
Hide resolved
base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_kernel.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_output.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/unblinded_output.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_kernel.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_output.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/output_features.rs
Outdated
Show resolved
Hide resolved
applications/tari_app_grpc/src/conversions/transaction_output.rs
Outdated
Show resolved
Hide resolved
c7f58d0
to
f220835
Compare
base_layer/core/src/transactions/transaction/output_features_version.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_input_version.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction/transaction_kernel_version.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but you need to remember to update the genesis block header as well as the MMR has now changed.
I've also forgot to add version to the TransactionInput hash. Added that as well. The genesis block is updated. |
Added |
80c3d0a
to
b8bdf1e
Compare
Description
Add versioning to Transactions.
How Has This Been Tested?
Some cucumber tests.