Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add versioning to transaction(input,output,kernel) #3709

Merged
merged 5 commits into from
Jan 18, 2022

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Jan 17, 2022

Description

Add versioning to Transactions.

How Has This Been Tested?

Some cucumber tests.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

Just some comments to consider.

Thanks.

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but you need to remember to update the genesis block header as well as the MMR has now changed.

@Cifko
Copy link
Contributor Author

Cifko commented Jan 18, 2022

I've also forgot to add version to the TransactionInput hash. Added that as well. The genesis block is updated.

@Cifko
Copy link
Contributor Author

Cifko commented Jan 18, 2022

Added Clippy.toml for the number of arguments (set to 15) and removed the #[allow(clippy::too_many_arguments)]. This is only done for the base_layer/core crate.

@aviator-app aviator-app bot merged commit 08995c7 into tari-project:development Jan 18, 2022
@Cifko Cifko deleted the add-version-simple branch June 23, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants