Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validator_node): add get_sidechain_block p2p rpc method #3803

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Feb 7, 2022

Description

  • Add get_sidechain_blocks to validator node p2p rpc
  • Use fixed 32-byte array for hashes on dan layer
  • Implement FromStr and fallible integer conversions for TemplateId
  • Remove asset_public_key from Instruction
  • Add necessary chain db calls
  • Add client call for get_sidechain_blocks
  • Adds mocks and basic tests for get_sidechain_blocks validator node rpc

Motivation and Context

Allow client to fetch sidechain instruction state from vn

How Has This Been Tested?

Manually

@sdbondi sdbondi changed the title fet(vn): add get_sidechain_block p2p rpc method feat(vn): add get_sidechain_block p2p rpc method Feb 7, 2022
@stringhandler stringhandler changed the title feat(vn): add get_sidechain_block p2p rpc method feat(validator_node): add get_sidechain_block p2p rpc method Feb 7, 2022
@sdbondi sdbondi force-pushed the vn-p2p-protocol branch 4 times, most recently from 5547ebc to 31797e9 Compare February 7, 2022 10:54
stringhandler
stringhandler previously approved these changes Feb 7, 2022
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for cleaning up some of the dirty bits I left

dan_layer/core/src/types.rs Outdated Show resolved Hide resolved
* development:
  refactor: reduce log level of some messages (tari-project#3804)
  ci: move Apple IDs into envs (tari-project#3797)
  feat: read asset definitions from base layer (tari-project#3802)
@delta1 delta1 removed the mq-failed label Feb 8, 2022
@aviator-app aviator-app bot merged commit 74df1d0 into tari-project:development Feb 8, 2022
@sdbondi sdbondi deleted the vn-p2p-protocol branch February 8, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants