feat: listen to terminal events in the watch mode #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
force-pushed
the
watch-key-press
branch
2 times, most recently
from
1e245e9
to
379f282
Compare
therustmonk
force-pushed
the
watch-key-press
branch
from
379f282
to
1a69a79
Compare
Because it affets the `--interval` parameter of the `watch` command.
therustmonk
force-pushed
the
watch-key-press
branch
from
1a69a79
to
21d6ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It adds an events stream to listens to key press events in the watch mode.
Another changes:
cli_loopfunction replaced with theCliLoopstruct that also moved to a separate modulestatus_loopreplaced with theCliLoopstructMotivation and Context
We should suggest the user how to exit the watch mode.
Also the cli loop reduced and divided into several parts.
How Has This Been Tested?
Manually