feat(core)!: define OutputFlags for side-chain contracts #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-output-flags-definition
branch
4 times, most recently
from
77fc23b
to
64033c4
Compare
hansieodendaal
previously approved these changes
May 11, 2022
|
Same here, LGTM, I believe they're exactly the features we need for the contract lifecycle |
| /// Output signals validator node acceptance to run a contract. | ||
| const CONTRACT_ACCEPT = 0x0400; | ||
| /// Output is a contract checkpoint. | ||
| const CONTRACT_CHECKPOINT = 0x0800; |
There was a problem hiding this comment.
We may need an additional flag for the initial checkpoint where all the contract acceptance UTXOs have to be spent into it - a slight nuance on the rules to be enforced.
There was a problem hiding this comment.
Isn't that going to be just the first checkpoint? Or does it need to be a custom output for that?
There was a problem hiding this comment.
I think you're right and we might need an abandoned flag so the asset owner can spend an abandoned checkpoint into that state to activate the emergency keys
There was a problem hiding this comment.
I left off the INITIAL_CHECKPOINT flag for now because even if we have it, we'd have to check that it is an INITIAL checkpoint (we can't trust the flag), in doing so we have done the work to detect it.
sdbondi
force-pushed
the
core-output-flags-definition
branch
from
64033c4
to
87ce0ac
Compare
sdbondi
force-pushed
the
core-output-flags-definition
branch
2 times, most recently
from
1a882aa
to
3464e21
Compare
sdbondi
force-pushed
the
core-output-flags-definition
branch
from
f7e11fa
to
c05327a
Compare
sdbondi
added
the
W-consensus_breaking
sdbondi
changed the title
sdbondi
force-pushed
the
core-output-flags-definition
branch
from
c05327a
to
06f97e6
Compare
stringhandler
previously approved these changes
May 17, 2022
stringhandler
approved these changes
May 17, 2022
stringhandler
pushed a commit
that referenced
this pull request
Jun 8, 2022
…or consensus enc changes (#4098) Description --- - mine a new nonce for `check_difficulty` and `check_share` tests - adds `detect_change_in_consensus_encoding` to detect changes in consensus encoding that require updates to pool miner code Motivation and Context --- Ref PR #4088 - `check_difficulty` and `check_share` tests are brittle because any change to consensus encoding causes them to fail. In that case, OutputFlags changed from a u8 to a u16. These tests now generate a new nonce and difficulty (takes ~1s on good hardware) and check that the FFI functions return matching results. This was done to eliminate the time and LOC needed to fix these tests in PRs that require changes to consensus encoding (many expected in the coming weeks/months). `detect_change_in_consensus_encoding` was added to make it clear that code changes in a given PR require an update to the pool miner code. How Has This Been Tested? --- The new tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines OutputFlags for side-chain contracts.
Motivation and Context
Define flags required for side-chain contracts. Deprecated flags are kept and can be removed in implementation PRs
for the various side-chain components.
How Has This Been Tested?
Unit and cucumber tests updated as necessary