refactor(core)!: replace OutputFlags with OutputType #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-change-output-flags-to-output-type
branch
from
47c7ad3
to
d851544
Compare
|
Nice those output flags had definitely gotten unwieldy concept ack |
sdbondi
force-pushed
the
core-change-output-flags-to-output-type
branch
8 times, most recently
from
a2ea334
to
f492d88
Compare
sdbondi
force-pushed
the
core-change-output-flags-to-output-type
branch
from
f492d88
to
e5dbb5d
Compare
stringhandler
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OutputFlagsWithOutputTypeenumMotivation and Context
Many new types of UTXOs are being added to the protocol. The OutputFlags type uses 2 bytes to represent up to 16 different types. These flags could not meaningfully be combined which is the primary use case of using bitflags.
This PR replaces the 2 byte bitflags with a 1-byte enum that represents the various output types available.
New dependency
serde_repr- allows repr enums to be de/serialized with serde as an integer (https://serde.rs/enum-number.html)How Has This Been Tested?
Existing tests updated as necessary