-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): unifying dan layer integration tests #4175
Merged
aviator-app
merged 10 commits into
tari-project:development
from
mrnaveira:fix-dan-tests
Jun 9, 2022
Merged
fix(test): unifying dan layer integration tests #4175
aviator-app
merged 10 commits into
tari-project:development
from
mrnaveira:fix-dan-tests
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
previously approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdbondi
previously approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM - Ack (tested in CI)
Approving because comments are minor / all tests passing. We reapprove if suggested changes are made.
Co-authored-by: Stan Bondi <sdbondi@users.noreply.github.com>
sdbondi
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@dan_layer
and@dan
tags, used only the@dan
tag in all related tests--command
option is no longer valid)@critical
, to run them on new PR submissions to avoid breaking changesMotivation and Context
It's desirable to be able to run all DAN related integration tests together under the same tag, and know if we are breaking existing functionalities when developing new features in the future.
How Has This Been Tested?
Now, the cucumber integration tests ran with
--tags "@dan and not @broken"
pass