Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): integration test for validator node is broken #4192

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

mrnaveira
Copy link
Contributor

Description

  • Returned a specific log line back to the standard output, to be able to detect that the validator node finished starting up from the integration tests
  • Fixed the compilation of the validator node application on integration test startup
  • Tagged the existing integration tests for contract acceptances as @critical so any broken changes on future pull requests will be spotted

Motivation and Context

We want to be able to run tests on validator node operations like contract acceptance. It was broken at some point.

How Has This Been Tested?

The existing integration test for contract acceptance, done through the validator node, now runs successfully

Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@aviator-app aviator-app bot merged commit 16d6ba5 into tari-project:development Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants