fix(wallet): handle not found rpc error in utxo scanning #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-cucumber-scanning-duplicate-scanned-block
branch
from
a0102ca
to
76dd43d
Compare
stringhandler
previously approved these changes
Jul 4, 2022
sdbondi
force-pushed
the
wallet-cucumber-scanning-duplicate-scanned-block
branch
from
c3d40bf
to
3b256e4
Compare
stringhandler
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
If a reorg has occurred on previously scanned UTXOs, the scanner will fail. It should handle this error by rescanning at that block height.
Always removing the previous scanned blocks that were not found may fix the UNIQUE key violation that has been seen cucumber tests. However, I was not able to reproduce the failure locally.
How Has This Been Tested?
In cucumber test
Partially manual (scanning works, but reorg case not tested)