Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel signature does not commit to all kernel fields #4365

Closed
SWvheerden opened this issue Jul 29, 2022 · 2 comments
Closed

Kernel signature does not commit to all kernel fields #4365

SWvheerden opened this issue Jul 29, 2022 · 2 comments
Assignees
@SWvheerden

Comments

@SWvheerden
Copy link
Collaborator

Currently, the kernel does not commit to all kernel fields.
We don't commit to the:

  • public excess
  • Features

We also need to commit to the new burning features: #4364
@SWvheerden SWvheerden mentioned this issue Jul 29, 2022
Merged
@SWvheerden SWvheerden self-assigned this Aug 1, 2022
aviator-app bot pushed a commit that referenced this issue Aug 2, 2022
@SWvheerden
feat!: add burned outputs (#4364)
60f3877 
Description
---
This Pr adds in the ability to create burned outputs. 
There will be a follow-up PR addressing the kernel mutability as currently the fields are mutable and need to be signed to block mutability, see: #4365. 

For added reasoning why this is needed see RFC: tari-project/rfcs#10

Full testing of this is also blocked by: #4360

How Has This Been Tested?
---
Unit and integration tests.
@SWvheerden SWvheerden mentioned this issue Aug 2, 2022
Merged
@SWvheerden
Copy link
Collaborator Author

PR: #4377

stringhandler pushed a commit that referenced this issue Aug 4, 2022
@SWvheerden
feat!: fix kernel mutability (#4377)
d25d726 
Description
---
Currently, the kernel has a mutability issue where the public excess, features, and new optional burn commitment is not committed to in the challenge.  
See issue: #4365

This is a breaking change as it changes every single kernel signature. 

This changes the challenge for the kernel to include those fields.  Because the kernel fields need to be signed by all parties, these needs fields must be decided at the start of the transaction. This required changes to the tx protocol as well. 

How Has This Been Tested?
---
Running all current unit tests and all critical cucumber tests.
@SWvheerden
Copy link
Collaborator Author

Fixed in #4377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SWvheerden