fix: config cleanup #4938
Merged
fix: config cleanup #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig preset; now passing initialized RandomXFactory in the initializer, same for `bypass_range_proof_verification` but passing just the setting
agubarev
changed the title
max_randomx_vms and bypass_range_proof_verification from BaseNodeStateMachineConfig [issue #4909]max_randomx_vms and bypass_range_proof_verification from BaseNodeStateMachineConfig issue #4909
agubarev
changed the title
max_randomx_vms and bypass_range_proof_verification from BaseNodeStateMachineConfig issue #4909
sdbondi
reviewed
Nov 22, 2022
sdbondi
approved these changes
Nov 23, 2022
agubarev
deleted the
issue-4909-cleanup_conflicting_base_node_configs
branch
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 23, 2022
* development: fix: config cleanup (tari-project#4938) fix(ci): update GHA release process (tari-project#4945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
max_randomx_vmsfromBaseNodeStateMachineConfigand the config preset, now passing the initialized RandomXFactory in via the initializer, same forbypass_range_proof_verificationbut passing only the settingMotivation and Context
#4909
There are a few duplicate config keys that exist in the base node config and the base node state machine config
meaning settings and behaviour could mismatch.
base_node.max_randomx_vms(this setting will not work)base_node.bypass_range_proof_verification(this setting will not work)base_node.force_sync_peers(this was fixed in #4647 but the fix is a bit hacky)tari/base_layer/core/src/base_node/state_machine_service/state_machine.rs
Line 52 in 956b279
https://github.com/tari-project/tari/blob/development/applications/tari_base_node/src/config.rs#L109
ref #4646
How Has This Been Tested?
manually