feat: add wallet ffi shutdown tests #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 12 suites +12 1h 25m 26s ⏱️ + 1h 25m 26s For more details on these failures, see this check. Results for commit c3c5575. ± Comparison against base commit 0bc62b4. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_wallet_ffi_shutdown
branch
4 times, most recently
from
04199b1
to
a6015ca
Compare
- Added wallet FFI shutdown tests to prove that all services have been terminted when the FFI `wallet_destroy` command has been run. - Added additional safeguards in the FFI `wallet_destroy` method to ensure the wallet has shut down.
hansieodendaal
force-pushed
the
ho_wallet_ffi_shutdown
branch
from
a6015ca
to
c3c5575
Compare
hansieodendaal
changed the title
sdbondi
approved these changes
Dec 7, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wallet_destroycommand has been run.wallet_destroymethod to ensure the wallet has shut down.Motivation and Context
See #5984
How Has This Been Tested?
Added
pub fn test_wallet_shutdown()in the wallet FFI library.What process can a PR reviewer use to test or verify this change?
Breaking Changes