Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate config settings #6029

Merged
merged 1 commit into from
Dec 9, 2023
Merged

fix: remove duplicate config settings #6029

merged 1 commit into from
Dec 9, 2023

Conversation

hansieodendaal
Copy link
Contributor

Description

Removed duplicate config settings in b_peer_seeds.toml introduced by a recent PR

Motivation and Context

See above

How Has This Been Tested?

Tested the clean config.toml creation with cargo run --release --bin minotari_node

What process can a PR reviewer use to test or verify this change?

Performa clean cargo run --release --bin minotari_node and review the created config.toml

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal
Remove duplicate config
39880e2 
Removed duplicate config settings in `b_peer_seeds.toml`
@hansieodendaal hansieodendaal mentioned this pull request Dec 9, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

Test Results (CI)

1 262 tests   1 262 ✔️  10m 50s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 39880e2.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Dec 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   13m 7s ⏱️ + 13m 7s
28 tests +28    2 ✔️ +  2  0 💤 ±0  26 ❌ +26 
80 runs  +80    2 ✔️ +  2  0 💤 ±0  78 ❌ +78 

For more details on these failures, see this check.

Results for commit 39880e2. ± Comparison against base commit 4d0b831.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Dec 9, 2023
@SWvheerden SWvheerden merged commit 662af28 into tari-project:development Dec 9, 2023
12 of 14 checks passed
@hansieodendaal hansieodendaal deleted the ho_remove_duplicate_config branch January 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansieodendaal @SWvheerden @ghpbot-tari-project