Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: potential overflow of coinbase calc #6306

Merged
merged 3 commits into from
Apr 26, 2024
Merged

fix: potential overflow of coinbase calc #6306

merged 3 commits into from
Apr 26, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

fix potential overflow of multiple coinbase grpc call

Motivation and Context

How Has This Been Tested?

tests

@SWvheerden SWvheerden requested a review from a team as a code owner April 24, 2024 13:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results (CI)

    2 files     80 suites   1h 28m 44s ⏱️
1 276 tests 1 275 ✅ 0 💤 1 ❌
2 549 runs  2 548 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 05dc068.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   31m 7s ⏱️ + 31m 7s
33 tests +33  31 ✅ +31  0 💤 ±0  2 ❌ +2 
37 runs  +37  32 ✅ +32  0 💤 ±0  5 ❌ +5 

For more details on these failures, see this check.

Results for commit 05dc068. ± Comparison against base commit cf579f5.

♻️ This comment has been updated with latest results.

hansieodendaal
hansieodendaal reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment below.

integration_tests/tests/steps/node_steps.rs Show resolved Hide resolved
@SWvheerden SWvheerden merged commit 030d389 into tari-project:development Apr 26, 2024
11 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fixcoinbase branch April 29, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronFeickert AaronFeickert AaronFeickert left review comments

@hansieodendaal hansieodendaal hansieodendaal left review comments

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SWvheerden @hansieodendaal @AaronFeickert @ghpbot-tari-project