Update fee vs amount being sent validation #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when the `SenderTransactionInitializer` validates the components of the transaction it is building it will check that if the fee is more than the amount being sent + the change. This PR updates this behaviour to check if the fee being sent is more than just the amounts being send, ignoring the change. This prevents the case where a large UTXO that produces a lot of change will still allow a transaction to be sent where the outbound amount is less than the fee.
stringhandler
approved these changes
Jan 29, 2021
stringhandler
added a commit
that referenced
this pull request
Jan 29, 2021
Changes since v0.8.0 - [#2587](#2587) Correct block times - [#2572](#2572) Fix console wallet runtime calls - [#2559](#2559) Add Cucumber to CI - [#2574](#2574) Update libwallet build for Github actions - [#2583](#2583) Remove "add one to port" hack in console wallet - [#2585](#2585) Move generated proto files to OUT_DIR - [#2584](#2584) Update fee vs amount being sent validation - [#2578](#2578) Fix submit block in integration test - [#2576](#2576) Remove Ridcully references from Stibbons code - [#2582](#2582) Remove generated proto files from tari_core - [#2577](#2577) Fix for auotmated wallet startup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when the
SenderTransactionInitializervalidates the components of the transaction it is building it will check that if the fee is more than the amount being sent + the change.This PR updates this behaviour to check if the fee being sent is more than just the amounts being send, ignoring the change. This prevents the case where a large UTXO that produces a lot of change will still allow a transaction to be sent where the outbound amount is less than the fee.
How Has This Been Tested?
Manual testing
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.