fix: fix transaction output hashing #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes in the source code base required the cucumber test environment to be updated. The newly introduced `class Blake256` was used and calculation of output features consensus bytes was consolidated. Some code organization improvements were done.
sdbondi
approved these changes
Aug 16, 2022
| @@ -82,7 +82,7 @@ module.exports = { | |||
| domainHashers: { | |||
| transactionKdf(label) { | |||
| return new DomainHashing( | |||
| `com.tari.base_layer.core.transactions.v0.kdf.${label}` | |||
| `com.tari.base_layer.core.transactions.kdf.v0.${label}` | |||
There was a problem hiding this comment.
Good catch, even though it's not used
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Aug 16, 2022
…ld-selector * development: fix: wrong ban reason (tari-project#4461) fix broken critical cucumber test (tari-project#4458) chore: remove Defunct L2 code (tari-project#4463) fix(ci): binary builds - remove tari_collectibles and lib deps for linux (tari-project#4454) feat(docker) :build tari docker images for launchpad (tari-project#4476) fix: fix transaction output hashing (tari-project#4483) chore: remove broken tag from working tests (tari-project#4471) fix: wallet always scan interactive payments (see tari-project#4452) (tari-project#4464) feat: remove total_txs and rename total_weight in mempool (tari-project#4474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The newly introduced
class Blake256was used and calculation of output features consensus bytes was consolidated. Some code organization improvements were done.Note: This change is also present in #4445.
Motivation and Context
Recent changes in the source code base required the cucumber test environment to be updated.
How Has This Been Tested?
When running locally:
npm test -- --tags "@critical and not @long-running and not @broken" --profile "none"