feat!: apply hashing api to the mmr #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_hashing_api_mmr
branch
from
5e7ec6e
to
e1d1684
Compare
base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
Outdated
Show resolved
Hide resolved
hansieodendaal
force-pushed
the
ho_hashing_api_mmr
branch
2 times, most recently
from
4427dab
to
bdbc854
Compare
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_hashing_api_mmr
branch
4 times, most recently
from
cd04142
to
16da4af
Compare
This was referenced Aug 15, 2022
aviator-app bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
Description --- The newly introduced `class Blake256` was used and calculation of output features consensus bytes was consolidated. Some code organization improvements were done. _**Note:** This change is also present in #4445._ Motivation and Context --- Recent changes in the source code base required the cucumber test environment to be updated. How Has This Been Tested? --- When running locally: `npm test -- --tags "@critical and not @long-running and not @broken" --profile "none"` ``` 26 scenarios (26 passed) 373 steps (373 passed) 18m27.251s (executing steps: 18m17.959s) ```
Added hashing API to the MMR by virtue of forcing the hashing type to be `D: Digest + DomainDigest` instead of only `D: Digest` at the lower level MMR methods and functions.
hansieodendaal
force-pushed
the
ho_hashing_api_mmr
branch
from
16da4af
to
5c7805f
Compare
stringhandler
approved these changes
Aug 16, 2022
sdbondi
reviewed
Aug 16, 2022
|
|
||
| hash_domain!( | ||
| MmrBenchTestHashDomain, | ||
| "com.tari.tari_project.base_layer.mmr.bemches", |
There was a problem hiding this comment.
@hansieodendaal Just noticed a type-o here
There was a problem hiding this comment.
Oh nm just a test so it's not a problem :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fulfillment for #4395:
D: Digest + DomainDigestinstead of onlyD: Digestat the lower level MMR methods and functions.Fixed cucumber function
const getTransactionOutputHash = function (output)Motivation and Context
Domain separated hashing as per the
tari_cryptohashing API is needed for the MMR.How Has This Been Tested?