Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Encrypted cloud backup (password) #425

Closed
talmahaj opened this issue Jun 9, 2020 · 9 comments
Closed

[Feature] Encrypted cloud backup (password) #425

talmahaj opened this issue Jun 9, 2020 · 9 comments
Assignees

Comments

@talmahaj
Copy link

talmahaj commented Jun 9, 2020

See parent

@Tas4tari
Copy link

Tas4tari commented Jul 3, 2020

@Tas4tari
Copy link

Tas4tari commented Jul 3, 2020

i think we have to also input the existing password for a password change

i'm guessing it would just add another text field before the first one, but we need the copy for that one too

@SerhiiShovkoplias the overlap may become a thing with this third text field:
https://app.zeplin.io/project/5dbdf1a40bdfd3832e35c9c5/screen/5efed93db9928c41744f9b07

@Tas4tari
Copy link

Tas4tari commented Jul 3, 2020

Video from @SerhiiShovkoplias : https://drive.google.com/file/d/1rzovxaMuTQDzzoPX74cu1A5oyXOJ9HBL/view

Response from Tal:
Looks great. Just two small things:

  • The progress loader icon hangs for a while without any movement and then fills in all the way... Can we have it so it's never completely still? Like maybe its just a dot spinning inside or something if we're waiting for progress to start? Kind of like the one in Android that is always spinning
  • Let's use the language "Backing up" instead of "backuping." I actually made a screen for you with the copy for this and the text below it, since I missed it in the spec: https://app.zeplin.io/project/5dbdf1a40bdfd3832e35c9c5/screen/5efed5f81c864776a3c79cdf

@Tas4tari
Copy link

Tas4tari commented Jul 3, 2020

Received from Tal:
As for the last case you guys brought up on standup today (@kutsal I think it was you who explained it?) around add/change pw and the next backup having to be tied together as far as success/failure, what do you think of retrying 3 times and then displaying the relevant error message while keeping user on the select password screen? This way they can resolve whatever the issue is and get back to that screen to try to save again once they return to the app. If for whatever reason they close the app altogether and reopen it, they'll have to start over again, but it won't be unexpected because they never got the feedback that their password was successfully saved (or had any reason to think it might've been, e.g. if they were sent back to the prior screen)

@Tas4tari
Copy link

Tas4tari commented Jul 15, 2020

@Jasonvdb @SerhiiShovkoplias Please see added requirement and design as discussed in stand up:
Added Requirement:
Password Error message:

  • Error should only appear once first password field is no longer in focus (that is, once user taps out of it, usually in order to enter it again in the pw confirmation field)
  • Design: http://zpl.io/VxzWw4X
    I have also updated the parent ticket with this
    cc @talmahaj

This was referenced Jul 15, 2020
@Anziskavds
Copy link

Tested on iOS on version 0.3.0 on an iPhone 7.

Results:
Enabled iCloud backups - User has not yet encrypted their wallet (Adding a Password): Tested successfully

Please note that "Verify that the "Secure Your Backup" button is enabled as per the designs: https://app.zeplin.io/project/5dbdf1a40bdfd3832e35c9c5/screen/5ef40bfefb40e1a33d60c236" tested successfully. There is no screenshot for this because I forgot to take one before I clicked on the button but it did test successfully.

Screenshots:

IMG_0502.PNG

IMG_0503.PNG

IMG_0504.PNG

IMG_0505.PNG

IMG_0506.PNG

IMG_0507.PNG

IMG_0508.PNG

IMG_0509.PNG

IMG_0510.PNG

IMG_0511.PNG

@Anziskavds
Copy link

Tested on iOS on version 0.3.0 on an iPhone 7.

Results:
Enabled iCloud backups - User has already encrypted their wallet (Changing a Password): Tested successfully

Screenshots:

IMG_0512.PNG

IMG_0513.PNG

IMG_0514.PNG

IMG_0515.PNG

IMG_0516.PNG

IMG_0517.PNG

IMG_0518.PNG

IMG_0519.PNG

IMG_0520.PNG

IMG_0521.PNG

IMG_0522.PNG

IMG_0523.PNG

IMG_0524.PNG

IMG_0526.PNG

IMG_0527.PNG

@Anziskavds
Copy link

Anziskavds commented Jul 16, 2020

Tested Disabled Backups and I found that the "Failed to create backup" error message doesn't have the writing below "Failed to create backup". It only pops up "Failed to create backup". I see on the video @SerhiiShovkoplias made https://drive.google.com/file/d/1rzovxaMuTQDzzoPX74cu1A5oyXOJ9HBL/view it has writhing below the "Failed to create backup" title. Which is correct? @Tas4tari @@talmahaj @kukabi @Jasonvdb

IMG_0533.PNG

@Anziskavds
Copy link

Anziskavds commented Jul 17, 2020

Tested on iOS on version 0.3.0 on an iPhone 7. There are a few issues found while testing this which separate tickets were created for each of them. Functionality tested successfully so I'm closing this ticket.

Test report: https://app.zenhub.com/files/213589121/2093af94-a659-4609-894c-5742a882e81e/download

Separate issues found and added to Github:

#482
#484
#485
#486
#487
#488

cc @Tas4tari @SerhiiShovkoplias @Jasonvdb @kukabi @@talmahaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants